Skip to content

Add atensecurity/pulumi-thoth to community package list#11056

Open
atensecurity-bot wants to merge 1 commit into
pulumi:masterfrom
atensecurity:community-package-atensecurity-pulumi-thoth
Open

Add atensecurity/pulumi-thoth to community package list#11056
atensecurity-bot wants to merge 1 commit into
pulumi:masterfrom
atensecurity:community-package-atensecurity-pulumi-thoth

Conversation

@atensecurity-bot

Copy link
Copy Markdown

This adds atensecurity/pulumi-thoth to the Pulumi community package list.

Requested as part of initial community registry publication for the Thoth Pulumi provider.

@atensecurity-bot atensecurity-bot requested a review from a team as a code owner May 19, 2026 06:44
@ch3ck

ch3ck commented May 19, 2026

Copy link
Copy Markdown

@fnune PR updated here

@fnune fnune left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before this can merge, the following need to land in the upstream atensecurity/pulumi-thoth repo and a new tagged release:

Required

  • Add docs/_index.md and docs/installation-configuration.md. Both 404 at v0.1.11 and main; the docs/ directory does not exist. Required by the checklist; they render the registry overview and install pages.
  • Reconcile declared vs. published languages. The schema's language block declares ["csharp", "go", "nodejs", "python"], but only Python and .NET are published. Either publish npm + prime pkg.go.dev for Go, or drop nodejs / go from the schema so the registry doesn't advertise install steps that don't work.
  • Bring the PyPI release in line with the provider version. pulumi-thoth is at 0.1.0; provider is at v0.1.11. Python publish step appears to have stopped after the initial release; check .goreleaser.yml.

FYI

  • Issue #10871 categorises this as "Native", but the entrypoint imports pulumi-terraform-bridge/v3/pkg/pf/tfbridge. It's a Terraform Plugin Framework bridge. No effect on publishing.

Re-tag, then this PR can be re-reviewed in place.

fnune added a commit that referenced this pull request May 19, 2026
Three changes after a real run against #11056 surfaced friction:

1. Comment-style brevity rules for all generated PR comments, review
   bodies, and close messages: under 150 words, no em-dashes, no
   opening preamble or closing flourish, one-line asks with the why
   in a parenthetical or link. The previous default produced ~400-word
   walls of text with em-dashes throughout, against the global style
   the maintainer has set.

2. SDK presence probe is now driven by the schema's language map, not
   an assumption that all four (TS/Python/Go/C#) are required. A
   declared language with no published SDK is Fail; a published SDK
   that lags the provider version by more than one minor is also Fail
   (the schema promises an API the SDK does not expose); undeclared
   languages are not probed.

3. Obvious packaging-config bugs in published SDK names (doubled
   tokens like Foo.Pulumi.Bar.Bar from a misconfigured tfgen
   rootNamespace) are now an explicit Warn pattern, not just "best
   effort, varies."

## Test plan

- Re-ran the comment redraft from the #11056 review with the new
  brevity rules: 120 words vs the previous 400, no em-dashes,
  identical action items.
- Confirmed against atensecurity/pulumi-thoth that its schema
  declares all four languages, so the SDK probe still flags the
  missing npm publish and the lagging PyPI publish; behaviour on
  that PR is unchanged but the skill no longer over-asks for
  providers that intentionally ship fewer SDKs.
@atensecurity-bot atensecurity-bot force-pushed the community-package-atensecurity-pulumi-thoth branch from 1f77f8c to b00201c Compare June 23, 2026 18:01
@atensecurity-bot

atensecurity-bot commented Jun 23, 2026

Copy link
Copy Markdown
Author

@fnune, Refreshing this PR with the latest branch update and v0.1.12 release state.

Update made on June 23, 2026:

  • Branch atensecurity:community-package-atensecurity-pulumi-thoth refreshed onto latest master
  • PR head is now b00201cc346a403fb3f1f76b5d8a46fadf80ba61

atensecurity/pulumi-thoth checks for v0.1.12:

  • Docs exist at tag v0.1.12: docs/_index.md, docs/installation-configuration.md
  • npm: @atensec/pulumi-thoth = 0.1.12
  • PyPI: pulumi-thoth = 0.1.12
  • NuGet: AtenSecurity.Pulumi.Thoth.Thoth = 0.1.12
  • Go module tags include v0.1.12

Could we get this re-reviewed in place?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants